public-Repo-Mirrors/Top-Bar-Organizer
1
Fork 0
mirror of https://gitlab.gnome.org/julianschacher/top-bar-organizer.git synced 2025-10-27 15:19:09 +00:00
Code Releases Activity

Other: Mark AppIndicator/KStatusNotifierItem addition as broken

Browse Source
This commit is contained in:
Julian 2023-01-27 21:44:59 +01:00
parent 7b1c030325
commit ba373e9e49
Signed by: julian
GPG Key ID: 094C2AC34192FA11
2 changed files with 25 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.yml
View File

@ -22,3 +22,4 @@ rules:
- argsIgnorePattern: "^_"
globals:
imports: readonly
log: readonly

41
src/extension.js
View File

@ -136,24 +136,31 @@ class Extension {
// Handle the case where the new item is a
// AppIndicator/KStatusNotifierItem.
// Note: This code is currently broken, since the extension
// providing AppIndicator/KStatusNotifierItems
// (appindicatorsupport@rgcjonas.gmail.com) doesn't give us an id on
// addition anymore and therefore we don't know which program/id the
// AppIndicator/KStatusNotifierItem belongs to.
// So just throw an error for now.
if (role.startsWith("appindicator-")) {
switch (box) {
case "left":
boxOrder = this.settings.get_strv("left-box-order");
this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders);
this.settings.set_strv("left-box-order", boxOrder);
break;
case "center":
boxOrder = this.settings.get_strv("center-box-order");
this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders);
this.settings.set_strv("center-box-order", boxOrder);
break;
case "right":
boxOrder = this.settings.get_strv("right-box-order");
this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders, true);
this.settings.set_strv("right-box-order", boxOrder);
break;
}
throw new Error("AppIndicator/KStatusNotifierItem addition is currently broken.");
// switch (box) {
// case "left":
// boxOrder = this.settings.get_strv("left-box-order");
// this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders);
// this.settings.set_strv("left-box-order", boxOrder);
// break;
// case "center":
// boxOrder = this.settings.get_strv("center-box-order");
// this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders);
// this.settings.set_strv("center-box-order", boxOrder);
// break;
// case "right":
// boxOrder = this.settings.get_strv("right-box-order");
// this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders, true);
// this.settings.set_strv("right-box-order", boxOrder);
// break;
// }
}
// Get the resolved box orders for all boxes.