From ba373e9e49ac93b0f906395a3fd8210b2cd6a271 Mon Sep 17 00:00:00 2001
From: Julian Schacher <julian@jsts.xyz>
Date: Fri, 27 Jan 2023 21:44:59 +0100
Subject: [PATCH] Other: Mark AppIndicator/KStatusNotifierItem addition as
 broken

---
 .eslintrc.yml    |  1 +
 src/extension.js | 41 ++++++++++++++++++++++++-----------------
 2 files changed, 25 insertions(+), 17 deletions(-)

diff --git a/.eslintrc.yml b/.eslintrc.yml
index c6874ae..2cfc4ef 100644
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -22,3 +22,4 @@ rules:
     - argsIgnorePattern: "^_"
 globals:
   imports: readonly
+  log: readonly
diff --git a/src/extension.js b/src/extension.js
index 6e30234..5ab5ef2 100644
--- a/src/extension.js
+++ b/src/extension.js
@@ -136,24 +136,31 @@ class Extension {
 
             // Handle the case where the new item is a
             // AppIndicator/KStatusNotifierItem.
+            // Note: This code is currently broken, since the extension
+            // providing AppIndicator/KStatusNotifierItems
+            // (appindicatorsupport@rgcjonas.gmail.com) doesn't give us an id on
+            // addition anymore and therefore we don't know which program/id the
+            // AppIndicator/KStatusNotifierItem belongs to.
+            // So just throw an error for now.
             if (role.startsWith("appindicator-")) {
-                switch (box) {
-                    case "left":
-                        boxOrder = this.settings.get_strv("left-box-order");
-                        this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders);
-                        this.settings.set_strv("left-box-order", boxOrder);
-                        break;
-                    case "center":
-                        boxOrder = this.settings.get_strv("center-box-order");
-                        this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders);
-                        this.settings.set_strv("center-box-order", boxOrder);
-                        break;
-                    case "right":
-                        boxOrder = this.settings.get_strv("right-box-order");
-                        this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders, true);
-                        this.settings.set_strv("right-box-order", boxOrder);
-                        break;
-                }
+                throw new Error("AppIndicator/KStatusNotifierItem addition is currently broken.");
+                // switch (box) {
+                //     case "left":
+                //         boxOrder = this.settings.get_strv("left-box-order");
+                //         this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders);
+                //         this.settings.set_strv("left-box-order", boxOrder);
+                //         break;
+                //     case "center":
+                //         boxOrder = this.settings.get_strv("center-box-order");
+                //         this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders);
+                //         this.settings.set_strv("center-box-order", boxOrder);
+                //         break;
+                //     case "right":
+                //         boxOrder = this.settings.get_strv("right-box-order");
+                //         this._appIndicatorKStatusNotifierItemManager.handleAppIndicatorKStatusNotifierItemItem(indicator.container, role, boxOrder, boxOrders, true);
+                //         this.settings.set_strv("right-box-order", boxOrder);
+                //         break;
+                // }
             }
 
             // Get the resolved box orders for all boxes.