27 Commits

Author	SHA1	Message	Date
June	ff75debabc	fix: have onDrop handler methods correctly return booleans ... Have the onDrop methods, used as handlers for Gtk.DropTarget drop signals, return booleans as required by Gtk.DropTarget. https://docs.gtk.org/gtk4/signal.DropTarget.drop.html This change doesn't seem to have a practical impact, but its good to follow the API correctly anyway.	2025-06-11 00:55:10 +02:00
June	979e770057	update: properly handle top bar items of Task Up UltraLite extension ... Since the Task Up UltraLite extension creates a bunch of top bar items as part of its functionality, the Top Bar Organizer settings would get spammed with items, making them hard to navigate and making it practically impossible to manage the top bar items of the Task Up UltraLite extension itself. Therefore introduce functionality for properly handling the Task Up UltraLite top bar items, by grouping them internally and just exposing a single Top Bar Organizer settings item for all the Task Up UltraLite items, which then allows to manage the Task Up UltraLite top bar items nicely. This fixes #25: https://gitlab.gnome.org/june/top-bar-organizer/-/issues/25 Task Up UltraLite extension: https://extensions.gnome.org/extension/7700/task-up-ultralite/	2025-06-10 03:54:30 +02:00
June	185a48c857	fix: use row title to make settings window not break for long item names ... Use the title of the PrefsBoxOrderItemRow (AdwActionRow) for the item name instead of a label in the prefix. Aside from generally being more correct, item names now wrap correctly, avoiding the settings window breaking (being cut off by default to the right with even the close button not showing, until resizing) with long item names.	2025-06-09 19:53:12 +02:00
Julian Schacher	7f86e92e85	Refactor: Clean up unused import	2023-10-05 14:59:46 +02:00
Julian Schacher	d903274d73	Other: Require trailing commas for multiline for most ... Require trailing commas for multiline for arrays, objects, imports and exports and disallow trailing commas for functions. Do this by updating the ESLint config and fixing new complaints. The reason for this change are the resulting future cleaner version diffs. Also see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas https://eslint.org/docs/latest/rules/comma-dangle	2023-10-05 14:50:36 +02:00
Julian Schacher	a77c6d2f2b	Refactor: Install forget action using install_action as well	2023-10-04 03:58:10 +02:00
Julian Schacher	9b7ab0614c	Feature: Add move up and down buttons to make the prefs keyboard access. ... Don't use CONSTRUCT_ONLY anymore to be able to use private properties (or any properties at all it seems).	2023-10-04 03:57:42 +02:00
Julian Schacher	a1188d5684	Breaking: Migrate extension to the new ESM system of GNOME 45 ... Migrate with the help of, among others, the following resources: https://blogs.gnome.org/shell-dev/2023/09/02/extensions-in-gnome-45/ https://gjs.guide/extensions/upgrading/gnome-shell-45.html Only support GNOME Shell version 45, since only 45 is compatible with the new ESM system. Since panel._originalAddToPanelBox is no longer valid, just overwrite using the prototype on disable. Add "sourceType": "module" to eslintrc.yml to get rid of: "Parsing error: 'import' and 'export' may appear only with 'sourceType: module'" See here: https://eslint.org/docs/latest/use/configure/language-options#specifying-parser-options	2023-10-04 03:57:35 +02:00
Julian Schacher	58a078c15c	Refactor: Use private fields instead of pref. with _, where suitable	2023-01-28 23:51:43 +01:00
Julian Schacher	cedb54ed64	Other: Disallow omitting curly braces and enforce one true brace style ... Do this by updating the ESLint config accordingly and also fix new complaints.	2023-01-28 23:34:15 +01:00
Julian Schacher	dc7ad73db4	Other: Handle ESLint complaints	2023-01-24 19:33:11 +01:00
Julian Schacher	2e5bcd4e81	Other: Move "use strict"; before ESLint config comment everywhere	2023-01-24 19:24:14 +01:00
Julian Schacher	d7ec1156e2	Refactor: Setup and handle all of DND scroll. in #setupDNDScroll func. ... Also handle drag events in this function so connecting to "drag-end" in widgets with "GtkDragSource" and a `globalThis` `ScrollManager` instance aren't needed.	2023-01-24 18:33:15 +01:00
Julian Schacher	503fdcb90d	Refactor: Build Menu in UI file	2023-01-22 21:02:58 +01:00
Julian Schacher	e07411f9fd	Refactor: Use private instance methods instead of prefixing with _	2023-01-22 20:35:13 +01:00
Julian Schacher	596c8d3cdc	Refactor: Setup Drag Source and Drop Targets in UI files	2023-01-22 20:06:02 +01:00
Julian Schacher	c54e24c151	Refactor: Add ScrollManager instance to globalThis ... Do this so that we don't have to pass the `ScrollManager` instance to each `PrefsBoxOrderItemRow` instance. This is useful for future refactors.	2023-01-22 19:28:49 +01:00
Julian Schacher	2f9f4d1a3f	Refactor: Use constructor instead of _init	2023-01-22 15:16:56 +01:00
Julian Schacher	7ed9329f2d	Refactor: Move UI files and gschema file to more standard locations	2023-01-22 14:59:40 +01:00
Julian Schacher	d383908d5f	Other: Remove license notice, since its unnecessary and annoying	2023-01-04 23:57:21 +01:00
Julian Schacher	3299686041	Update: Show drag icon when reordering PrefsBoxOrderItemRows using DND ... The following code from GNOME/gnome-control-center was used as a reference to make this code work: - ab7d752de9/panels/search/cc-search-panel-row.c (L96) - ab7d752de9/panels/search/cc-search-panel-row.c (L84)	2022-10-24 01:07:24 +02:00
Julian Schacher	249f3554d5	Breaking: Make preferences usable again and support Gnome Shell 42 ... Make the preferences usable again (and look good) by using an `AdwPreferencesPage` as well as various other libadwaita features (like `AdwPreferencesGroup`, style classes, ...). Also get rid of some code, which now doesn't seem to be necessary anymore (making sure no horizontal scrollbar shows and setting a default size for the preferences window). This change is marked as "Breaking", since I assume `AdwPreferencesPage` doesn't work in Gnome Shell 40 and because I changed the supported Gnome Shell version to 42 accordingly.	2022-10-23 22:10:36 +02:00
Julian Schacher	e76b24e813	Feature: Add forget action for top bar items ... This forget action removes the top bar item from the top bar order representation, which is present in the settings, and then saves the top bar order. This action is intended for forgetting top bar items, which aren't present in the top bar anymore, so that the user can clean up their settings. So if an item isn't in the top bar at the time of action activation, activating the action removes it from the saved top bar order. If an item is in the top bar at the time of action activation, the item position just gets lost (since it gets automatically re-added to the top bar order).	2021-07-05 08:41:08 +02:00
Julian Schacher	309e2c07b9	Refactor: Let PrefsBoxOrderItemRow handle item association ... Let `PrefsBoxOrderItemRow` handle the association of itself with an item itself. Doing so makes the code cleaner, since the association isn't done externally anymore.	2021-07-05 07:58:01 +02:00
Julian Schacher	bd69f816eb	Refactor: Move logic for saving box order to PrefsBoxOrderListBox ... Move the logic for saving the box order represented by a `PrefsBoxOrderListBox` (and its `PrefsBoxOrderItemRows`) to the `PrefsBoxOrderListBox` class. This makes the code cleaner and allows for easy reuse of the logic in the future.	2021-07-05 07:46:08 +02:00
Julian Schacher	edfa50f254	Update: Scroll preferences window content on Drag-and-Drop ... Scroll the content of the preferences window on Drag-and-Drop, when the mouse is in the upper or lower part of the content of the preferences window. This helps a user, who has e.g. a lot of items, but the preferences window with a low height, to easily move any item to any position.	2021-07-04 05:16:32 +02:00
Julian Schacher	1f8305a2f0	Refactor: Move some classes from src/prefs.js into own files ... Introduce for these new files a new directory `src/prefsModules`.	2021-05-27 00:17:41 +02:00