From ff75debabc7a5133b9dd4508a1e9bb3c39298a14 Mon Sep 17 00:00:00 2001
From: June <june@jsts.xyz>
Date: Wed, 11 Jun 2025 00:55:10 +0200
Subject: [PATCH] fix: have onDrop handler methods correctly return booleans

Have the onDrop methods, used as handlers for Gtk.DropTarget drop
signals, return booleans as required by Gtk.DropTarget.
https://docs.gtk.org/gtk4/signal.DropTarget.drop.html
This change doesn't seem to have a practical impact, but its good to
follow the API correctly anyway.
---
 src/prefsModules/PrefsBoxOrderItemRow.js              | 4 +++-
 src/prefsModules/PrefsBoxOrderListEmptyPlaceholder.js | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/prefsModules/PrefsBoxOrderItemRow.js b/src/prefsModules/PrefsBoxOrderItemRow.js
index f0e4b49..2891213 100644
--- a/src/prefsModules/PrefsBoxOrderItemRow.js
+++ b/src/prefsModules/PrefsBoxOrderItemRow.js
@@ -86,7 +86,7 @@ export default class PrefsBoxOrderItemRow extends Adw.ActionRow {
     onDrop(_target, value, _x, _y) {
         // If `this` got dropped onto itself, do nothing.
         if (value === this) {
-            return;
+            return false;
         }
 
         // Get the GtkListBoxes of `this` and the drop value.
@@ -138,5 +138,7 @@ export default class PrefsBoxOrderItemRow extends Adw.ActionRow {
             valueListBox.saveBoxOrderToSettings();
             valueListBox.determineRowMoveActionEnable();
         }
+
+        return true;
     }
 }
diff --git a/src/prefsModules/PrefsBoxOrderListEmptyPlaceholder.js b/src/prefsModules/PrefsBoxOrderListEmptyPlaceholder.js
index 0fa0db3..927cda2 100644
--- a/src/prefsModules/PrefsBoxOrderListEmptyPlaceholder.js
+++ b/src/prefsModules/PrefsBoxOrderListEmptyPlaceholder.js
@@ -31,5 +31,7 @@ export default class PrefsBoxOrderListEmptyPlaceholder extends Gtk.Box {
         ownListBox.determineRowMoveActionEnable();
         valueListBox.saveBoxOrderToSettings();
         valueListBox.determineRowMoveActionEnable();
+
+        return true;
     }
 }