public-Repo-Mirrors/Top-Bar-Organizer
1
Fork 0
mirror of https://gitlab.gnome.org/julianschacher/top-bar-organizer.git synced 2025-10-27 15:19:09 +00:00
Code Releases Activity

Refactor: Move individual top bar box ordering into own method

Browse Source 
Move the individual top bar box ordering into own method, so that this
method can be used elsewhere in the future to easily order a single box.
This commit is contained in:
Julian 2021-05-16 20:17:17 +02:00
parent 2f0ecddfc8
commit fd21ecb189
Signed by: julian
GPG Key ID: 094C2AC34192FA11
1 changed files with 37 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
src/extension.js
View File

@ -12,7 +12,7 @@ class Extension {
enable() {
this._addNewItemsToBoxOrders();
this._orderTopBarItems();
this._orderTopBarItemsOfAllBoxes();
this._overwritePanelAddToPanelBox();
}
@ -81,33 +81,49 @@ class Extension {
}
/**
* This method orders the top bar items according to the configured box
* orders.
* This methods orders the top bar items of all boxes according to the
* configured box orders using `this._orderTopBarItems`.
*/
_orderTopBarItems() {
// Get valid box orders.
const validLeftBoxOrder = this._createValidBoxOrder("left");
const validCenterBoxOrder = this._createValidBoxOrder("center");
const validRightBoxOrder = this._createValidBoxOrder("right");
_orderTopBarItemsOfAllBoxes() {
this._orderTopBarItems("left");
this._orderTopBarItems("center");
this._orderTopBarItems("right");
}
// Go through the items (or rather their roles) of a box and order the
// box accordingly.
const orderBox = (boxOrder, box) => {
for (let i = 0; i < boxOrder.length; i++) {
const role = boxOrder[i];
/**
* This method orders the top bar items of the specified box according to
* the configured box orders.
* @param {string} box - The box to order.
*/
_orderTopBarItems(box) {
// Get the valid box order.
const validBoxOrder = this._createValidBoxOrder(box);
// Get the relevant box of `Main.panel`.
let panelBox;
switch (box) {
case "left":
panelBox = Main.panel._leftBox;
break;
case "center":
panelBox = Main.panel._centerBox;
break;
case "right":
panelBox = Main.panel._rightBox;
break;
}
// Go through the items (or rather their roles) of the validBoxOrder and
// order the panelBox accordingly.
for (let i = 0; i < validBoxOrder.length; i++) {
const role = validBoxOrder[i];
// Get the indicator container associated with the current role.
const associatedIndicatorContainer = Main.panel.statusArea[role].container;
box.set_child_at_index(associatedIndicatorContainer, i);
panelBox.set_child_at_index(associatedIndicatorContainer, i);
}
}
// Order the top bar items.
orderBox(validLeftBoxOrder, Main.panel._leftBox);
orderBox(validCenterBoxOrder, Main.panel._centerBox);
orderBox(validRightBoxOrder, Main.panel._rightBox);
}
/**
* This function creates a valid box order for the given box.
* @param {string} box - The box to return the valid box order for.