From 49c46bf33f3ee7b2c3bddfbe3cf641de464b994e Mon Sep 17 00:00:00 2001 From: Julian Schacher Date: Mon, 21 Jun 2021 18:46:34 +0200 Subject: [PATCH] Update: Don't create object as result of `init()` being called Create `this.settings` on enable instead of on init/creation, so that no objects get created as a result of `init()` being called. See here for the relevant review: https://extensions.gnome.org/review/25308 And for the relevant documentation: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization --- src/extension.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/extension.js b/src/extension.js index 7740169..efacc6d 100644 --- a/src/extension.js +++ b/src/extension.js @@ -30,10 +30,11 @@ const BoxOrderCreator = Me.imports.extensionModules.BoxOrderCreator; class Extension { constructor() { - this.settings = ExtensionUtils.getSettings(); } enable() { + this.settings = ExtensionUtils.getSettings(); + // Create an instance of AppIndicatorKStatusNotifierItemManager to handle AppIndicator/KStatusNotifierItem items. this._appIndicatorKStatusNotifierItemManager = new AppIndicatorKStatusNotifierItemManager.AppIndicatorKStatusNotifierItemManager();