From 2ef16f310c6652197ed8ea6b734ea336595c73a9 Mon Sep 17 00:00:00 2001
From: Julian Schacher <julian@jsts.xyz>
Date: Wed, 25 Jan 2023 20:40:16 +0100
Subject: [PATCH] Fix: Null out `this.settings` on extension disable

See here for the relevant review:
https://extensions.gnome.org/review/38364
And for the relevant documentation:
https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects
---
 src/extension.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/extension.js b/src/extension.js
index f233bd6..6e30234 100644
--- a/src/extension.js
+++ b/src/extension.js
@@ -76,6 +76,8 @@ class Extension {
         for (const handlerId of this._settingsHandlerIds) {
             this.settings.disconnect(handlerId);
         }
+
+        this.settings = null;
     }
 
     ////////////////////////////////////////////////////////////////////////////