From 1b5ba38617ad68ccda9d2629352366fbbafdbd12 Mon Sep 17 00:00:00 2001
From: Julian Schacher <julian@jsts.xyz>
Date: Sun, 29 Jan 2023 03:24:17 +0100
Subject: [PATCH] Refactor: Rename `this.settings` to `this._settings`

Do this to indicate that this is a "private" field.
---
 src/extension.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/extension.js b/src/extension.js
index 599a5ee..e197917 100644
--- a/src/extension.js
+++ b/src/extension.js
@@ -14,7 +14,7 @@ class Extension {
     }
 
     enable() {
-        this.settings = ExtensionUtils.getSettings();
+        this._settings = ExtensionUtils.getSettings();
 
         this._boxOrderManager = new BoxOrderManager.BoxOrderManager();
 
@@ -32,7 +32,7 @@ class Extension {
         // Handle changes of configured box orders.
         this._settingsHandlerIds = [];
         const addConfiguredBoxOrderChangeHandler = (box) => {
-            let handlerId = this.settings.connect(`changed::${box}-box-order`, () => {
+            let handlerId = this._settings.connect(`changed::${box}-box-order`, () => {
                 this.#handleNewItemsAndOrderTopBar();
             });
             this._settingsHandlerIds.push(handlerId);
@@ -50,11 +50,11 @@ class Extension {
 
         // Disconnect signals.
         for (const handlerId of this._settingsHandlerIds) {
-            this.settings.disconnect(handlerId);
+            this._settings.disconnect(handlerId);
         }
         this._boxOrderManager.disconnectSignals();
 
-        this.settings = null;
+        this._settings = null;
         this._boxOrderManager = null;
     }