From 114e1335d174dd19a3ed21a1496f9e6794737a38 Mon Sep 17 00:00:00 2001 From: June Date: Thu, 12 Jun 2025 01:30:43 +0200 Subject: [PATCH] refactor: remove unneces. check for empty array in #getResolvedBoxOrder Remove unnecessary check for empty array in #getResolvedBoxOrder as nothing happens when the array is empty anyway. --- src/extensionModules/BoxOrderManager.ts | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/extensionModules/BoxOrderManager.ts b/src/extensionModules/BoxOrderManager.ts index 317da51..cfb4dbe 100644 --- a/src/extensionModules/BoxOrderManager.ts +++ b/src/extensionModules/BoxOrderManager.ts @@ -215,13 +215,8 @@ export default class BoxOrderManager extends GObject.Object { roles = this.#taskUpUltraLiteItemRoles; } - // If there are no roles associated, continue. - if (roles.length === 0) { - continue; - } - - // Otherwise create a new resolved box order item for each role and - // add it to the resolved box order. + // Create a new resolved box order item for each role and add it to + // the resolved box order. for (const role of roles) { const newResolvedBoxOrderItem = JSON.parse(JSON.stringify(resolvedBoxOrderItem)); newResolvedBoxOrderItem.role = role;